TraversalExtensions sample notebook #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbroome
reviewed
Sep 21, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
jongeorge1
reviewed
Oct 11, 2022
idg10
reviewed
Oct 11, 2022
Comment on lines
25
to
29
| public async Task IsEqualToOne(int x) | ||
| { | ||
| bool result = x.Equals(1); | ||
| Console.WriteLine(result); | ||
| } |
There was a problem hiding this comment.
If you wrote this in Visual Studio, it would issue a warning because although you've declared this as async you don't seem to have used await, so this isn't really async.
I'd consider adding something like
await Task.Delay(TimeSpan.FromSeconds(0.5));so that a) it is async, and b) it becomes reasonable clear that ForEachAsync waits for the Task returned for each item to complete before moving onto the next.
There was a problem hiding this comment.
Using await in all async methods now
jongeorge1
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.