Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TraversalExtensions sample notebook #192
TraversalExtensions sample notebook #192
Changes from 15 commits
afbf08e
5ecf406
5beba8a
cfd570b
7bd08a0
415fa33
6f40148
c0f2926
0e42b0c
96ebafb
345fc74
52401d9
3c68767
0bc112b
b56159d
dcdcedf
208ea1a
ced64b2
3ccfdc6
2d7b63a
9c33e44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wrote this in Visual Studio, it would issue a warning because although you've declared this as
async
you don't seem to have usedawait
, so this isn't reallyasync
.I'd consider adding something like
so that a) it is async, and b) it becomes reasonable clear that
ForEachAsync
waits for theTask
returned for each item to complete before moving onto the next.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
await
in allasync
methods now