Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseApp: CheckTx can't safely access header #475

Closed
ebuchman opened this issue Feb 17, 2018 · 1 comment
Closed

BaseApp: CheckTx can't safely access header #475

ebuchman opened this issue Feb 17, 2018 · 1 comment

Comments

@ebuchman
Copy link
Member

msCheck/msDeliver/header setting used to all happen together, but #438 noted that msCheck can never be nil (so we can run CheckTx right away).

#470 fixes that, but notes that CheckTx now can't safely access the header.

See comments in #438.

Might be solved by #353
@ebuchman ebuchman mentioned this issue Feb 17, 2018
Closed
@ebuchman
Copy link
Member Author

Solved by #476

kocubinski pushed a commit that referenced this issue Jul 4, 2023
@mergify @iboss-ptk
Reemitting events from cache context in gov endblockers (#465) (#475)
cbb746a 
Co-authored-by: Dev Ojha <[email protected]>
(cherry picked from commit 4c20864)

Co-authored-by: Supanat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebuchman