baseapp: ctxCheck and ctxDeliver, begin/endBlocker #476
Conversation
ebuchman
force-pushed
the
begin-end-block
branch
from
cb80d77
to
958a632
Compare
Codecov Report
@@ Coverage Diff @@
## develop #476 +/- ##
==========================================
+ Coverage 53.18% 53.89% +0.7%
==========================================
Files 27 27
Lines 1538 1542 +4
==========================================
+ Hits 818 831 +13
+ Misses 668 660 -8
+ Partials 52 51 -1 |
| // .msCheck and .ctxCheck are set on initialization and reset on Commit. | ||
| // .msDeliver and .ctxDeliver are (re-)set on BeginBlock. | ||
| // .valUpdates accumulate in DeliverTx and reset in BeginBlock. | ||
| // QUESTION: should we put valUpdates in the ctxDeliver? |
There was a problem hiding this comment.
we will not use it for the hub, everything is updated through endblock... I'd vote to remove, but maybe there are other use cases to leave it in (but then again, maybe we should just enforce val updates only in endblock)
|
End block needs to be able to update for validator set changes, may as well add that into this PR... Also I think it may be unnecessarily confusing to introduce |
How can you do that? Don't we need to expose SetBeginBlocker and SetEndBlocker to enable this ? |
ebuchman
changed the title
…mos#465) (cosmos#476) * Reemitting events from cache context in gov endblockers (cosmos#465) Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit 4c20864) * updates --------- Co-authored-by: Supanat <[email protected]> Co-authored-by: Roman <[email protected]>
Begin/EndBlock handlers: #346
Background context for a block: #353