Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST Client Oddities #4845

Closed
4 tasks
alexanderbez opened this issue Aug 5, 2019 · 0 comments · Fixed by #4848
Closed
4 tasks

REST Client Oddities #4845

alexanderbez opened this issue Aug 5, 2019 · 0 comments · Fixed by #4848
Assignees
Labels

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Aug 5, 2019

Oddity 1

Start a localnet with a REST client listening. Any POST request will result in:

{
    "error": "http: request body too large"
}

Digging into the Go source code, I see MaxBytesReader is called. However, it's called with a max size of 0. Furthermore, even if I manually set MaxBytesReader in ReadRESTReq, I notice the constructor gets called TWICE and not only that, but the first time N is 0! It's as if the handler is being executed twice.

  1. Why is MaxBytesReader being called twice?
  2. Why is the 1st call being invoked with N: 0?

Note: This does not happen with the LCD tests

Oddity 2

While updating Gaia to use the latest SDK master, I noticed certain queries in the LCD tests internally had stale CLIContext values. Namely, the height.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants