Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on rpcserver.DefaultConfig() to inherit default config values #4848

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 5, 2019

This fixes a small regression inadvertently introduced
in 99df748 that caused the REST server to return
"http: request body too large" on POST requests handling.

closes: #4845


  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]
  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

This fixes a small regression inadvertently introduced
in 99df748 that caused the REST server to return
"http: request body too large" on POST requests handling.
@alessio alessio marked this pull request as ready for review August 5, 2019 16:59
@alessio alessio added the R4R label Aug 5, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit cf19802 into master Aug 5, 2019
@alexanderbez alexanderbez deleted the alessio/fix-request-body-too-large branch August 5, 2019 17:13
alexanderbez pushed a commit that referenced this pull request Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #4848 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4848   +/-   ##
=======================================
  Coverage   54.11%   54.11%           
=======================================
  Files         269      269           
  Lines       17216    17216           
=======================================
  Hits         9317     9317           
  Misses       7209     7209           
  Partials      690      690

yun-yeo pushed a commit to terra-money/classic-core that referenced this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST Client Oddities
2 participants