fix(upgrades): perform no-op if from and to migration version are equal

[fedekunze]

Description

When the migration version is the same (from = to), no logic is required so we can perform a no-op for the module.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[aaronc]

Is this affecting 0.45/0.46? Is there some failure case you can document @fedekunze ?

[codecov]

Codecov Report

Merging #12174 (05fb17e) into main (2094c13) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #12174   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files         672      672           
  Lines       71060    71060           
=======================================
  Hits        46913    46913           
  Misses      21483    21483           
  Partials     2664     2664           

Impacted Files	Coverage Δ
types/module/configurator.go	15.55% <0.00%> (ø)

[alexanderbez]

ACK

[alexanderbez]

@fedekunze can you add a quick changelog entry please 🙏

[ValarDragon]

I don't understand, this doesn't change anything?

Its handled in the for loop on line 103

[alexanderbez]

@ValarDragon is correct -- closing.

[fedekunze]

@alexanderbez @ValarDragon @aaronc if the migration for an old version gets deleted for any reason, that means that the upgrade will fail because the migration with return an error on L99. This happened to us during a testnet upgrade: evmos/evmos#588

The fact that you cannot remove legacy migration logic is NOT documented anywhere and is an unexpected behavior

[alexanderbez]

Yes, that's fine, I don't see this change as contentious anyway, so we can merge 👍