Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrades): perform no-op if from and to migration version are equal #12174

Merged
merged 5 commits into from
Jun 8, 2022
Merged

fix(upgrades): perform no-op if from and to migration version are equal #12174

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
693573e
fix(upgrades): perform no-op if 'from' and 'to' migration version are…
fedekunze Jun 7, 2022
0105e0b
Merge branch 'main' into fedekunze/migration-no-op
fedekunze Jun 7, 2022
7c9ce76
Merge branch 'main' into fedekunze/migration-no-op
fedekunze Jun 7, 2022
8ac0d75
Merge branch 'main' into fedekunze/migration-no-op
fedekunze Jun 8, 2022
05fb17e
Merge branch 'main' into fedekunze/migration-no-op
alexanderbez Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/module/configurator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ func (c configurator) RegisterMigration(moduleName string, fromVersion uint64, h
// runModuleMigrations runs all in-place store migrations for one given module from a
// version to another version.
func (c configurator) runModuleMigrations(ctx sdk.Context, moduleName string, fromVersion, toVersion uint64) error {
// No-op if toVersion is the initial version.
if toVersion <= 1 {
// No-op if toVersion is the initial version or if the version is unchanged.
if toVersion <= 1 || fromVersion == toVersion {
return nil
}

Expand Down