Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-rosetta #14888

Merged
merged 1 commit into from
Feb 2, 2023
Merged

test: fix test-rosetta #14888

merged 1 commit into from
Feb 2, 2023

Conversation

JulianToledano
Copy link
Contributor

Description

Closes:
#14855
Sets --api.enable true so grpc server is started


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JulianToledano JulianToledano requested a review from a team as a code owner February 2, 2023 16:05
@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Feb 2, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you rebase?

@julienrbrt julienrbrt enabled auto-merge (squash) February 2, 2023 16:11
@julienrbrt julienrbrt linked an issue Feb 2, 2023 that may be closed by this pull request
@julienrbrt julienrbrt merged commit 79f5140 into cosmos:main Feb 2, 2023
samricotta pushed a commit that referenced this pull request Feb 7, 2023
@JulianToledano JulianToledano deleted the fix/rosetta-tests branch February 9, 2023 18:39
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta Issues and PR related to Rosetta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rosetta job are failing on main
2 participants