Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow grpc server enabled even when api off #14890

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 2, 2023

Description

I wondered why #14888 needed to enable the API server, while it was needing only the GRPC server.
Turns out this PR #14652 added a regression, where the gRPC server was only started when the API server is (as gRPC-Web and gRPC-Gateway are on the same port, we need a gRPC instance there).

This PR adds a condition to still start the gRPC server even when the API is disabled.
We can then revert #14888 as well.

No changelog required because we are on main and this was never released.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner February 2, 2023 17:01
@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Feb 2, 2023
@julienrbrt julienrbrt changed the title chore: fix regression, allow grpc server enabled even when api off fix: allow grpc server enabled even when api off Feb 2, 2023
@julienrbrt julienrbrt merged commit 12394c8 into main Feb 2, 2023
@julienrbrt julienrbrt deleted the julien/grpc branch February 2, 2023 19:34
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta Issues and PR related to Rosetta Type: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants