R4R: mint use total supply instead of power #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3654 +/- ##
===========================================
+ Coverage 60.79% 60.81% +0.01%
===========================================
Files 189 189
Lines 14170 14173 +3
===========================================
+ Hits 8615 8619 +4
+ Misses 5011 5010 -1
Partials 544 544 |
5 tasks
alexanderbez
approved these changes
Feb 14, 2019
| @@ -100,7 +100,8 @@ type ValidatorSet interface { | |||
|
|
|||
| Validator(Context, ValAddress) Validator // get a particular validator by operator address | |||
| ValidatorByConsAddr(Context, ConsAddress) Validator // get a particular validator by consensus address | |||
| TotalPower(Context) Int // total power of the validator set | |||
| TotalBondedTokens(Context) Int // total bonded tokens within the validator set | |||
There was a problem hiding this comment.
interested in the rationale behind the interface change here.
There was a problem hiding this comment.
Power refers to Tendermint Power which is intended to be used nearly nowhere besides for Tendermint (and slashing which needs to interface with tendermint responses) - this interface didn't make a difference pre-Tendermint Power Reduction (#3400) but now these two things are intended to mean very different values
There was a problem hiding this comment.
Agreed with @rigelrozanski - this is much clearer, thanks
cwgoes
approved these changes
Feb 15, 2019
| @@ -100,7 +100,8 @@ type ValidatorSet interface { | |||
|
|
|||
| Validator(Context, ValAddress) Validator // get a particular validator by operator address | |||
| ValidatorByConsAddr(Context, ConsAddress) Validator // get a particular validator by consensus address | |||
| TotalPower(Context) Int // total power of the validator set | |||
| TotalBondedTokens(Context) Int // total bonded tokens within the validator set | |||
There was a problem hiding this comment.
Agreed with @rigelrozanski - this is much clearer, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3646
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: