Generalise auth/types.StdSignature #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4507 +/- ##
==========================================
+ Coverage 53.17% 53.18% +0.01%
==========================================
Files 259 259
Lines 16191 16193 +2
==========================================
+ Hits 8610 8613 +3
+ Misses 6935 6934 -1
Partials 646 646 |
fedekunze
previously requested changes
Jun 7, 2019
fedekunze
reviewed
Jun 7, 2019
fedekunze
reviewed
Jun 7, 2019
| simSig := StdSignature{PubKey: pubkey} | ||
| if len(sig.Signature) == 0 { | ||
| if len(sig.GetSignature()) == 0 { |
There was a problem hiding this comment.
what about creating a new IsEmpty() method to the interface ?
There was a problem hiding this comment.
This is the only occurrence - plus, IsEmpty() might turn out to be ambiguous. What is the emptiness check being carried upon? Should IsEmpty() return true when signature is not present or only when both the sig and the key are nil?
alessio
force-pushed
the
alessio/generalise-stdsignature
branch
from
525b6d3
to
d11aca7
Compare
alexanderbez
reviewed
Jun 7, 2019
alexanderbez
reviewed
Jun 7, 2019
alexanderbez
added
ready-for-review
T: API Breaking
alexanderbez
added a commit
that referenced
this pull request
Jun 7, 2019
This reverts commit a32d5a4.
alessio
pushed a commit
that referenced
this pull request
Jun 8, 2019
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
New Signature interface available in the top level types package. auth.StdSignature implements such interface. User defined auth module can now define their own custom signature types. Work carried out in the context of the following issues: - cosmos#4488 - cosmos#4487
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
This reverts commit a32d5a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Signature interface available in the top level types package.
auth.StdSignature implements such interface. User defined auth module can now
define their own custom signature types.
Work carried out in the context of the following issues:
Decouple auth module from other SDK top-level core packages #4488
Remove X package dependency - beside exported package #4487
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: