Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: Generalize auth/types.StdSignature (#4507) #4512

Merged
merged 1 commit into from
Jun 8, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

This reverts commit a32d5a4. I think we should first discuss what it is exactly we want to abstract out in terms of x/auth & it's dependencies.

A signature is nothing more than just a []byte and an accompanying crypto.PubKey which is already an interface. There is no need to further abstract this out. It's also not worth the amino storage overhead.

@ValarDragon suggested we have an Authenticator interface which is just a wrapper for VerifyBytes.

/cc @alessio @rigelrozanski


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #4512 into master will decrease coverage by 0.03%.
The diff coverage is 52.17%.

@@            Coverage Diff            @@
##           master   #4512      +/-   ##
=========================================
- Coverage   53.23%   53.2%   -0.04%     
=========================================
  Files         259     259              
  Lines       16206   16204       -2     
=========================================
- Hits         8628    8621       -7     
- Misses       6932    6937       +5     
  Partials      646     646

@alessio alessio merged commit dc84c99 into master Jun 8, 2019
@alessio alessio deleted the bez/revert-4507 branch June 8, 2019 10:04
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants