Add proto compatible x/distribution tx cli #5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
anilcse
reviewed
Apr 6, 2020
anilcse
reviewed
Apr 6, 2020
sahith-narahari
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
fedekunze
reviewed
Apr 7, 2020
alexanderbez
suggested changes
Apr 7, 2020
|
Looks great @sahith-narahari, thanks! Just a few minor bits of feedback. |
fedekunze
changed the title
alexanderbez
approved these changes
Apr 8, 2020
fedekunze
added
the
A:automerge
|
@sahith-narahari mind updating the branch one last time? 🙏 It's out-of-date |
|
@fedekunze updated |
aaronc
reviewed
Apr 8, 2020
| txf := tx.NewFactoryFromCLI(inBuf). | ||
| WithTxGenerator(txg). | ||
| WithAccountRetriever(ar) | ||
| cliCtx := context.NewCLIContextWithInputAndFrom(inBuf, args[0]).WithMarshaler(m) |
There was a problem hiding this comment.
Should be NewCLIContextWithInput as args[0] actually doesn't point to anything - this will probably cause an out of bounds panic.
There was a problem hiding this comment.
Thanks for the review @aaronc, I see there's same issue in multiple modules. I addressed them all in a seperate PR
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #5864
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)