Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proto compatible community spend cli tx #6215

Merged
merged 12 commits into from
Jun 9, 2020
Merged

Add proto compatible community spend cli tx #6215

merged 12 commits into from
Jun 9, 2020

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented May 13, 2020 •
edited
Loading

Description

Ref: #5941
This PR fixes the example for FundCommunityProposal and eliminates splitAndApply which was replaced by newSplitAndApply as part of recent migration.

@auto-comment
Copy link

auto-comment bot commented May 13, 2020 •
edited by sahith-narahari
Loading

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@codecov
Copy link

codecov bot commented May 13, 2020 •
edited
Loading

Codecov Report

Merging #6215 into master will increase coverage by 0.03%.
The diff coverage is 16.36%.

@@            Coverage Diff             @@
##           master    #6215      +/-   ##
==========================================
+ Coverage   55.54%   55.57%   +0.03%     
==========================================
  Files         452      452              
  Lines       27340    27322      -18     
==========================================
  Hits        15185    15185              
+ Misses      11064    11046      -18     
  Partials     1091     1091

anilcse
anilcse reviewed May 13, 2020
View reviewed changes
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just address one comment

x/distribution/client/cli/utils.go Outdated Show resolved Hide resolved
@sahith-narahari sahith-narahari marked this pull request as ready for review May 13, 2020 22:15
alexanderbez
alexanderbez approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Too what degree do the recent CLI changes need to be revised @aaronc ?

@aaronc
Copy link
Member

aaronc commented May 14, 2020

LGTM. Too what degree do the recent CLI changes need to be revised @aaronc ?

@alexanderbez a little bit but I think not too much. I think #5989 will likely still be relevant

@sahith-narahari sahith-narahari marked this pull request as draft June 7, 2020 12:46
@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2020

This pull request introduces 2 alerts when merging 3d97cc4 into 8bc645a - view on LGTM.com

new alerts:

  • 1 for Unreachable statement
  • 1 for Expression has no effect

@sahith-narahari
Copy link
Contributor Author

The scope of this PR changed after recent migrations, updated the description accordingly

cc\ @aaronc @alexanderbez

@sahith-narahari sahith-narahari marked this pull request as ready for review June 7, 2020 14:05
@sahith-narahari sahith-narahari requested review from aaronc and alexanderbez and removed request for hschoenburg June 7, 2020 14:30
fedekunze
fedekunze reviewed Jun 7, 2020
View reviewed changes
x/distribution/client/cli/tx.go
@@ -195,25 +197,14 @@ $ %s tx distribution set-withdraw-addr cosmos1gghjut3ccd8ay0zduzj64hwre2fxs9ld75

func NewFundCommunityPoolCmd(clientCtx client.Context) *cobra.Command {
cmd := &cobra.Command{
Use: "community-pool-spend [proposal-file]",
Use: "fund-community-pool [amount]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test case for this CLI cmd?

Copy link
Contributor Author

@sahith-narahari sahith-narahari Jun 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an existing WIP PR for adding more cli_tests(#6349). Will ensure to add a test for this

alexanderbez
alexanderbez approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 9, 2020
@mergify mergify bot merged commit 0786e68 into master Jun 9, 2020
@mergify mergify bot deleted the sahith/add-community-spend branch June 9, 2020 10:18
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilcse anilcse anilcse left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio Awaiting requested review from alessio

@clevinson clevinson Awaiting requested review from clevinson

@jgimeno jgimeno Awaiting requested review from jgimeno

@nylira nylira Awaiting requested review from nylira

@aaronc aaronc Awaiting requested review from aaronc

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI
Projects
None yet
Milestone
v0.40 [Stargate]
Development

Successfully merging this pull request may close these issues.
6 participants
@sahith-narahari @aaronc @anilcse @alexanderbez @fedekunze @clevinson