Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport/v0.41.x]: fix: bind values from env variables to flags #8488

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

troian
Copy link
Contributor

@troian troian commented Feb 2, 2021

allows clients access values in env variables

From: #8337

@troian
Copy link
Contributor Author

troian commented Feb 2, 2021

/cc @amaurymartiny

@amaury1093
Copy link
Contributor

amaury1093 commented Feb 2, 2021

@troian ah yeah, no worries then, I'll do a sprint myself to create backport PRs for the ones before this one 👍. Putting this to draft for now.

@amaury1093 amaury1093 marked this pull request as draft February 2, 2021 12:09
@amaury1093 amaury1093 added this to the v0.41.1 milestone Feb 2, 2021
@clevinson
Copy link
Contributor

Is there a corresponding PR for this fix in master already? I'm struggling to find what this relates to. Ideally this should be merged into master and then backported to the release/v0.41.x branch, right?

@alessio
Copy link
Contributor

alessio commented Feb 10, 2021

@clevinson #8337

@clevinson clevinson changed the title fix: bind values from env variables to flags [backport]: fix: bind values from env variables to flags Feb 10, 2021
@clevinson clevinson changed the title [backport]: fix: bind values from env variables to flags [backport/v0.41.x]: fix: bind values from env variables to flags Feb 10, 2021
@clevinson clevinson mentioned this pull request Feb 10, 2021
23 tasks
allows clients access values in env variables

Signed-off-by: Artur Troian <[email protected]>
@amaury1093 amaury1093 reopened this Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #8488 (95b67c7) into release/v0.41.x (2a5818c) will decrease coverage by 0.00%.
The diff coverage is 31.03%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.41.x    #8488      +/-   ##
===================================================
- Coverage            61.93%   61.92%   -0.01%     
===================================================
  Files                  611      611              
  Lines                35250    35241       -9     
===================================================
- Hits                 21831    21822       -9     
  Misses               11136    11136              
  Partials              2283     2283              
Impacted Files Coverage Δ
baseapp/grpcserver.go 2.70% <0.00%> (+0.13%) ⬆️
x/staking/keeper/keeper.go 56.66% <ø> (-1.40%) ⬇️
x/staking/keeper/validator.go 80.52% <ø> (+0.03%) ⬆️
client/grpc_query.go 29.16% <40.00%> (+0.90%) ⬆️
baseapp/grpcrouter.go 80.00% <50.00%> (-6.05%) ⬇️
server/grpc/server.go 62.50% <100.00%> (ø)
testutil/network/util.go 72.91% <100.00%> (ø)

@amaury1093 amaury1093 marked this pull request as ready for review February 16, 2021 11:01
@alessio
Copy link
Contributor

alessio commented Feb 16, 2021

cosmovisor tests are still failing - @jgimeno @fdymylja mind takinga a look please?

@fdymylja
Copy link
Contributor

cosmovisor tests are still failing - @jgimeno @fdymylja mind takinga a look please?

on it

@fdymylja
Copy link
Contributor

fdymylja commented Feb 16, 2021

cosmovisor tests are still failing - @jgimeno @fdymylja mind takinga a look please?

Unfortunately I cannot seem to get a consistent test running, I've been running those in ubuntu docker (same as the one in the CI), but I keep getting different test fails. Unfortunately I cannot even debug it, apparently, as the target build system is linux and setting up a dockerized debugger is too complex with win-docker.

@jgimeno
Copy link
Contributor

jgimeno commented Feb 16, 2021

Let me take a look

@clevinson clevinson merged commit 963de42 into release/v0.41.x Feb 17, 2021
@clevinson clevinson deleted the troian/backport-fix-env branch February 17, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants