build: bump Go to v1.20 #2409
Merged
build: bump Go to v1.20 #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainoe
requested review from
alexanderbez,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
MSalopek and
shaspitz
as code owners
mmulji-ic
reviewed
Apr 17, 2023
glnro
approved these changes
Apr 17, 2023
glnro
previously requested changes
Apr 17, 2023
Co-authored-by: lg <[email protected]>
|
@sainoe could you please get the linter check pass? |
|
@mpoke I think that the linter passes. There are just some golangci warning msgs for some files changed by this PR. |
mmulji-ic
reviewed
Apr 19, 2023
mmulji-ic
approved these changes
Apr 19, 2023
MSalopek
approved these changes
Apr 19, 2023
Yes. Bumping go is state-machine breaking! |
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2023
* bump Go to 1.19 * Bump Go to 1.20 * update docs * Update docs/getting-started/installation.md Co-authored-by: lg <[email protected]> * bump golangci in gh workflow * set actions/checkout version back to v3.5.2 * change go-version from 1.20 to 1.20.x in actions/setup-go * nit in gh workflow * first attempt to use two diff go version in gh workflows * 2nd attempt * update changelog * set user in e2e.Dockerfile * Run E2E docker containers using nonroot * update revive linter rules * revert changes in e2e.Dockerfile * attempt to fix gh workflow and sonarcloud error --------- Co-authored-by: lg <[email protected]> (cherry picked from commit cb523c0) # Conflicts: # .github/workflows/lint.yml # .github/workflows/sim-label.yml # .github/workflows/sims.yml # .github/workflows/test.yml
shaspitz
reviewed
May 17, 2023
| - uses: technote-space/[email protected] | ||
| with: | ||
| PATTERNS: | | ||
| **/**.go | ||
| go.mod | ||
| go.sum | ||
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: 1.18 |
There was a problem hiding this comment.
Why is this version 1.18?
shaspitz
added a commit
that referenced
this pull request
May 18, 2023
* build: bump Go to v1.20 (#2409) * bump Go to 1.19 * Bump Go to 1.20 * update docs * Update docs/getting-started/installation.md Co-authored-by: lg <[email protected]> * bump golangci in gh workflow * set actions/checkout version back to v3.5.2 * change go-version from 1.20 to 1.20.x in actions/setup-go * nit in gh workflow * first attempt to use two diff go version in gh workflows * 2nd attempt * update changelog * set user in e2e.Dockerfile * Run E2E docker containers using nonroot * update revive linter rules * revert changes in e2e.Dockerfile * attempt to fix gh workflow and sonarcloud error --------- Co-authored-by: lg <[email protected]> (cherry picked from commit cb523c0) # Conflicts: # .github/workflows/lint.yml # .github/workflows/sim-label.yml # .github/workflows/sims.yml # .github/workflows/test.yml * fix conflicts * missed one --------- Co-authored-by: Simon Noetzlin <[email protected]> Co-authored-by: Shawn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2282
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change