-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump Go to v1.20 (backport #2409) #2499
Conversation
* bump Go to 1.19 * Bump Go to 1.20 * update docs * Update docs/getting-started/installation.md Co-authored-by: lg <[email protected]> * bump golangci in gh workflow * set actions/checkout version back to v3.5.2 * change go-version from 1.20 to 1.20.x in actions/setup-go * nit in gh workflow * first attempt to use two diff go version in gh workflows * 2nd attempt * update changelog * set user in e2e.Dockerfile * Run E2E docker containers using nonroot * update revive linter rules * revert changes in e2e.Dockerfile * attempt to fix gh workflow and sonarcloud error --------- Co-authored-by: lg <[email protected]> (cherry picked from commit cb523c0) # Conflicts: # .github/workflows/lint.yml # .github/workflows/sim-label.yml # .github/workflows/sims.yml # .github/workflows/test.yml
.github/workflows/test.yml
Outdated
@@ -117,21 +122,31 @@ jobs: | |||
- uses: actions/[email protected] | |||
with: | |||
fetch-depth: 0 | |||
<<<<<<< HEAD | |||
- uses: actions/setup-go@v3 | |||
with: | |||
go-version: 1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- uses: technote-space/[email protected] | ||
with: | ||
PATTERNS: | | ||
**/**.go | ||
go.mod | ||
go.sum | ||
- uses: actions/setup-go@v4 | ||
with: | ||
go-version: 1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed conflicts, LGTM. There are a couple spots that 1.18 are still used but I've kept things consistent with #2409
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is an automatic backport of pull request #2409 done by Mergify.
Cherry-pick of cb523c0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com