Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Payee grpc query and CLI #1493

Merged
merged 22 commits into from
Jun 9, 2022
Merged

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Jun 6, 2022

Description

  • Adding Payee grpc query and associated CLI

Needs: #1491
This PR includes the additions from the above and should be merged after the initial work in #1491

NOTE: this is one of many PRs to complete the feature work referenced in: #1477


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #1493 (5ae77f6) into main (57aa5ec) will decrease coverage by 0.00%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   80.33%   80.32%   -0.01%     
==========================================
  Files         166      166              
  Lines       12238    12251      +13     
==========================================
+ Hits         9831     9841      +10     
- Misses       1946     1948       +2     
- Partials      461      462       +1     
Impacted Files Coverage Δ
modules/apps/29-fee/keeper/grpc_query.go 75.54% <76.92%> (+0.10%) ⬆️

@damiannolan damiannolan changed the title feat: adding DistributionAddress grpc query and CLI feat: adding Payee grpc query and CLI Jun 8, 2022
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @damiannolan!

@damiannolan damiannolan merged commit 2c76973 into main Jun 9, 2022
@damiannolan damiannolan deleted the damian/1477-query-distaddr branch June 9, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants