Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Payee grpc query and CLI #1493

Merged
merged 22 commits into from
Jun 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a0291bd
[WIP] adding RegisterDistributionAddress rpc endpoint and implementat…
damiannolan Jun 3, 2022
55e69b1
updating tests
damiannolan Jun 5, 2022
29abd2e
adding registered distribution addresses to genesis state
damiannolan Jun 5, 2022
522dd3c
refactor and update validate genesis tests
damiannolan Jun 5, 2022
9de95cd
adding grpc query and cli for distribution address rpc endpoint
damiannolan Jun 6, 2022
e09d0d3
adding cli for register distribution address rpc
damiannolan Jun 6, 2022
defc821
Merge branch 'damian/1477-ics29-register-distaddr' into damian/1477-g…
damiannolan Jun 6, 2022
935dfec
Merge branch 'damian/1477-ics29-register-distaddr' into damian/1477-q…
damiannolan Jun 6, 2022
e4e7d01
renaming RegisterDistributionAddress rpc to RegisterPayee
damiannolan Jun 7, 2022
9f77b1d
renaming RegisterDistributionAddress to RegisterPayee
damiannolan Jun 7, 2022
b53d8af
updating godocs and field ordering
damiannolan Jun 7, 2022
3b2ccda
updating inline comment
damiannolan Jun 7, 2022
92f92d4
Merge branch 'damian/1477-ics29-register-distaddr' into damian/1477-g…
damiannolan Jun 7, 2022
d302509
renaming to regsitered payees and propagating changes in genesis
damiannolan Jun 8, 2022
fde1732
updating godoc in keeper.go
damiannolan Jun 8, 2022
9e0cc43
Update modules/apps/29-fee/keeper/keeper_test.go
damiannolan Jun 8, 2022
d7b4bc1
Merge branch 'main' into damian/1477-genesis-distaddrs
damiannolan Jun 8, 2022
e9a65dc
Merge branch 'damian/1477-genesis-distaddrs' of github.com:cosmos/ibc…
damiannolan Jun 8, 2022
4f8952a
Merge branch 'damian/1477-genesis-distaddrs' into damian/1477-query-d…
damiannolan Jun 8, 2022
8058abc
renaming query and types to align with payee address naming convention
damiannolan Jun 8, 2022
f25d61f
Merge branch 'main' into damian/1477-query-distaddr
damiannolan Jun 8, 2022
5ae77f6
Merge branch 'main' into damian/1477-query-distaddr
damiannolan Jun 8, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
225 changes: 225 additions & 0 deletions docs/client/swagger-ui/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1266,6 +1266,224 @@ paths:
type: string
tags:
- Query
'/ibc/apps/fee/v1/channels/{channel_id}/relayers/{relayer_address}/payee':
get:
summary: >-
Payee returns the registered payee address for a specific channel given
the relayer address
operationId: Payee
responses:
'200':
description: A successful response.
schema:
type: object
properties:
payee_address:
type: string
title: the payee address to which packet fees are paid out
title: QueryPayeeResponse defines the response type for the Payee rpc
default:
description: An unexpected error response
schema:
type: object
properties:
error:
type: string
code:
type: integer
format: int32
message:
type: string
details:
type: array
items:
type: object
properties:
type_url:
type: string
description: >-
A URL/resource name that uniquely identifies the type of
the serialized

protocol buffer message. This string must contain at
least

one "/" character. The last segment of the URL's path
must represent

the fully qualified name of the type (as in

`path/google.protobuf.Duration`). The name should be in
a canonical form

(e.g., leading "." is not accepted).


In practice, teams usually precompile into the binary
all types that they

expect it to use in the context of Any. However, for
URLs which use the

scheme `http`, `https`, or no scheme, one can optionally
set up a type

server that maps type URLs to message definitions as
follows:


* If no scheme is provided, `https` is assumed.

* An HTTP GET on the URL must yield a
[google.protobuf.Type][]
value in binary format, or produce an error.
* Applications are allowed to cache lookup results based
on the
URL, or have them precompiled into a binary to avoid any
lookup. Therefore, binary compatibility needs to be preserved
on changes to types. (Use versioned type names to manage
breaking changes.)

Note: this functionality is not currently available in
the official

protobuf release, and it is not used for type URLs
beginning with

type.googleapis.com.


Schemes other than `http`, `https` (or the empty scheme)
might be

used with implementation specific semantics.
value:
type: string
format: byte
description: >-
Must be a valid serialized protocol buffer of the above
specified type.
description: >-
`Any` contains an arbitrary serialized protocol buffer
message along with a

URL that describes the type of the serialized message.


Protobuf library provides support to pack/unpack Any values
in the form

of utility functions or additional generated methods of the
Any type.


Example 1: Pack and unpack a message in C++.

Foo foo = ...;
Any any;
any.PackFrom(foo);
...
if (any.UnpackTo(&foo)) {
...
}

Example 2: Pack and unpack a message in Java.

Foo foo = ...;
Any any = Any.pack(foo);
...
if (any.is(Foo.class)) {
foo = any.unpack(Foo.class);
}

Example 3: Pack and unpack a message in Python.

foo = Foo(...)
any = Any()
any.Pack(foo)
...
if any.Is(Foo.DESCRIPTOR):
any.Unpack(foo)
...

Example 4: Pack and unpack a message in Go

foo := &pb.Foo{...}
any, err := ptypes.MarshalAny(foo)
...
foo := &pb.Foo{}
if err := ptypes.UnmarshalAny(any, foo); err != nil {
...
}

The pack methods provided by protobuf library will by
default use

'type.googleapis.com/full.type.name' as the type URL and the
unpack

methods only use the fully qualified type name after the
last '/'

in the type URL, for example "foo.bar.com/x/y.z" will yield
type

name "y.z".



JSON

====

The JSON representation of an `Any` value uses the regular

representation of the deserialized, embedded message, with
an

additional field `@type` which contains the type URL.
Example:

package google.profile;
message Person {
string first_name = 1;
string last_name = 2;
}

{
"@type": "type.googleapis.com/google.profile.Person",
"firstName": <string>,
"lastName": <string>
}

If the embedded message type is well-known and has a custom
JSON

representation, that representation will be embedded adding
a field

`value` which holds the custom JSON in addition to the
`@type`

field. Example (for message [google.protobuf.Duration][]):

{
"@type": "type.googleapis.com/google.protobuf.Duration",
"value": "1.212s"
}
parameters:
- name: channel_id
description: unique channel identifier
in: path
required: true
type: string
- name: relayer_address
description: the relayer address to which the distribution address is registered
in: path
required: true
type: string
tags:
- Query
'/ibc/apps/fee/v1/channels/{packet_id.channel_id}/ports/{packet_id.port_id}/sequences/{packet_id.sequence}/incentivized_packet':
get:
summary: >-
Expand Down Expand Up @@ -13682,6 +13900,13 @@ definitions:
title: >-
QueryIncentivizedPacketsResponse defines the response type for the
IncentivizedPackets rpc
ibc.applications.fee.v1.QueryPayeeResponse:
type: object
properties:
payee_address:
type: string
title: the payee address to which packet fees are paid out
title: QueryPayeeResponse defines the response type for the Payee rpc
ibc.applications.fee.v1.QueryTotalAckFeesResponse:
type: object
properties:
Expand Down
34 changes: 34 additions & 0 deletions docs/ibc/proto-docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@
- [QueryIncentivizedPacketsForChannelResponse](#ibc.applications.fee.v1.QueryIncentivizedPacketsForChannelResponse)
- [QueryIncentivizedPacketsRequest](#ibc.applications.fee.v1.QueryIncentivizedPacketsRequest)
- [QueryIncentivizedPacketsResponse](#ibc.applications.fee.v1.QueryIncentivizedPacketsResponse)
- [QueryPayeeRequest](#ibc.applications.fee.v1.QueryPayeeRequest)
- [QueryPayeeResponse](#ibc.applications.fee.v1.QueryPayeeResponse)
- [QueryTotalAckFeesRequest](#ibc.applications.fee.v1.QueryTotalAckFeesRequest)
- [QueryTotalAckFeesResponse](#ibc.applications.fee.v1.QueryTotalAckFeesResponse)
- [QueryTotalRecvFeesRequest](#ibc.applications.fee.v1.QueryTotalRecvFeesRequest)
Expand Down Expand Up @@ -1126,6 +1128,37 @@ QueryIncentivizedPacketsResponse defines the response type for the IncentivizedP



<a name="ibc.applications.fee.v1.QueryPayeeRequest"></a>

### QueryPayeeRequest
QueryPayeeRequest defines the request type for the Payee rpc


| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| `channel_id` | [string](#string) | | unique channel identifier |
| `relayer_address` | [string](#string) | | the relayer address to which the distribution address is registered |






<a name="ibc.applications.fee.v1.QueryPayeeResponse"></a>

### QueryPayeeResponse
QueryPayeeResponse defines the response type for the Payee rpc


| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| `payee_address` | [string](#string) | | the payee address to which packet fees are paid out |






<a name="ibc.applications.fee.v1.QueryTotalAckFeesRequest"></a>

### QueryTotalAckFeesRequest
Expand Down Expand Up @@ -1235,6 +1268,7 @@ Query defines the ICS29 gRPC querier service.
| `TotalRecvFees` | [QueryTotalRecvFeesRequest](#ibc.applications.fee.v1.QueryTotalRecvFeesRequest) | [QueryTotalRecvFeesResponse](#ibc.applications.fee.v1.QueryTotalRecvFeesResponse) | TotalRecvFees returns the total receive fees for a packet given its identifier | GET|/ibc/apps/fee/v1/channels/{packet_id.channel_id}/ports/{packet_id.port_id}/sequences/{packet_id.sequence}/total_recv_fees|
| `TotalAckFees` | [QueryTotalAckFeesRequest](#ibc.applications.fee.v1.QueryTotalAckFeesRequest) | [QueryTotalAckFeesResponse](#ibc.applications.fee.v1.QueryTotalAckFeesResponse) | TotalAckFees returns the total acknowledgement fees for a packet given its identifier | GET|/ibc/apps/fee/v1/channels/{packet_id.channel_id}/ports/{packet_id.port_id}/sequences/{packet_id.sequence}/total_ack_fees|
| `TotalTimeoutFees` | [QueryTotalTimeoutFeesRequest](#ibc.applications.fee.v1.QueryTotalTimeoutFeesRequest) | [QueryTotalTimeoutFeesResponse](#ibc.applications.fee.v1.QueryTotalTimeoutFeesResponse) | TotalTimeoutFees returns the total timeout fees for a packet given its identifier | GET|/ibc/apps/fee/v1/channels/{packet_id.channel_id}/ports/{packet_id.port_id}/sequences/{packet_id.sequence}/total_timeout_fees|
| `Payee` | [QueryPayeeRequest](#ibc.applications.fee.v1.QueryPayeeRequest) | [QueryPayeeResponse](#ibc.applications.fee.v1.QueryPayeeResponse) | Payee returns the registered payee address for a specific channel given the relayer address | GET|/ibc/apps/fee/v1/channels/{channel_id}/relayers/{relayer_address}/payee|
| `CounterpartyAddress` | [QueryCounterpartyAddressRequest](#ibc.applications.fee.v1.QueryCounterpartyAddressRequest) | [QueryCounterpartyAddressResponse](#ibc.applications.fee.v1.QueryCounterpartyAddressResponse) | CounterpartyAddress returns the registered counterparty address for forward relaying | GET|/ibc/apps/fee/v1/channels/{channel_id}/relayers/{relayer_address}/counterparty_address|
| `FeeEnabledChannels` | [QueryFeeEnabledChannelsRequest](#ibc.applications.fee.v1.QueryFeeEnabledChannelsRequest) | [QueryFeeEnabledChannelsResponse](#ibc.applications.fee.v1.QueryFeeEnabledChannelsResponse) | FeeEnabledChannels returns a list of all fee enabled channels | GET|/ibc/apps/fee/v1/fee_enabled|
| `FeeEnabledChannel` | [QueryFeeEnabledChannelRequest](#ibc.applications.fee.v1.QueryFeeEnabledChannelRequest) | [QueryFeeEnabledChannelResponse](#ibc.applications.fee.v1.QueryFeeEnabledChannelResponse) | FeeEnabledChannel returns true if the provided port and channel identifiers belong to a fee enabled channel | GET|/ibc/apps/fee/v1/channels/{channel_id}/ports/{port_id}/fee_enabled|
Expand Down
1 change: 1 addition & 0 deletions modules/apps/29-fee/client/cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ func GetQueryCmd() *cobra.Command {
GetCmdTotalAckFees(),
GetCmdTotalTimeoutFees(),
GetCmdIncentivizedPacketsForChannel(),
GetCmdPayee(),
GetCmdCounterpartyAddress(),
GetCmdFeeEnabledChannel(),
GetCmdFeeEnabledChannels(),
Expand Down
39 changes: 39 additions & 0 deletions modules/apps/29-fee/client/cli/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,45 @@ func GetCmdTotalTimeoutFees() *cobra.Command {
return cmd
}

// GetCmdPayee returns the command handler for the Query/Payee rpc.
func GetCmdPayee() *cobra.Command {
cmd := &cobra.Command{
Use: "payee [channel-id] [relayer-address]",
Short: "Query the relayer payee address on a given channel",
Long: "Query the relayer payee address on a given channel",
Args: cobra.ExactArgs(2),
Example: fmt.Sprintf("%s query ibc-fee payee channel-5 cosmos1layxcsmyye0dc0har9sdfzwckaz8sjwlfsj8zs", version.AppName),
RunE: func(cmd *cobra.Command, args []string) error {
clientCtx, err := client.GetClientQueryContext(cmd)
if err != nil {
return err
}

if _, err := sdk.AccAddressFromBech32(args[1]); err != nil {
return err
}

queryClient := types.NewQueryClient(clientCtx)

req := &types.QueryPayeeRequest{
ChannelId: args[0],
RelayerAddress: args[1],
}

res, err := queryClient.Payee(cmd.Context(), req)
if err != nil {
return err
}

return clientCtx.PrintProto(res)
},
}

flags.AddQueryFlagsToCmd(cmd)

return cmd
}

// GetCmdCounterpartyAddress returns the command handler for the Query/CounterpartyAddress rpc.
func GetCmdCounterpartyAddress() *cobra.Command {
cmd := &cobra.Command{
Expand Down
18 changes: 18 additions & 0 deletions modules/apps/29-fee/keeper/grpc_query.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,24 @@ func (k Keeper) TotalTimeoutFees(goCtx context.Context, req *types.QueryTotalTim
}, nil
}

// Payee implements the Query/Payee gRPC method and returns the registered payee address to which packet fees are paid out
func (k Keeper) Payee(goCtx context.Context, req *types.QueryPayeeRequest) (*types.QueryPayeeResponse, error) {
if req == nil {
return nil, status.Error(codes.InvalidArgument, "empty request")
}

ctx := sdk.UnwrapSDKContext(goCtx)

payeeAddr, found := k.GetPayeeAddress(ctx, req.RelayerAddress, req.ChannelId)
if !found {
return nil, status.Errorf(codes.NotFound, "payee address not found for address: %s on channel: %s", req.RelayerAddress, req.ChannelId)
}

return &types.QueryPayeeResponse{
PayeeAddress: payeeAddr,
}, nil
}

// CounterpartyAddress implements the Query/CounterpartyAddress gRPC method and returns the registered counterparty address for forward relaying
func (k Keeper) CounterpartyAddress(goCtx context.Context, req *types.QueryCounterpartyAddressRequest) (*types.QueryCounterpartyAddressResponse, error) {
if req == nil {
Expand Down
Loading