Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daniyal/issue#1689 remove get versions #2539

Merged
merged 7 commits into from
Oct 17, 2022
Merged

Daniyal/issue#1689 remove get versions #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
48af0ab
refs#1690: removing 'GetVersions' from ConnectionI in core/exported/c…
Daniyal98 Oct 12, 2022
39da13b
Revert "refs#1690: removing 'GetVersions' from ConnectionI in core/ex…
Daniyal98 Oct 12, 2022
454518e
Merge branch 'cosmos:main' into main
Daniyal98 Oct 12, 2022
6d22516
issue#1689: removed GetVersions from ConnectionInterface
Daniyal98 Oct 12, 2022
acef7fd
Merge branch 'main' into daniyal/issue#1689_remove_GetVersions
crodriguezvega Oct 13, 2022
2d9638f
Update CHANGELOG.md
crodriguezvega Oct 14, 2022
5315ee0
Merge branch 'main' into daniyal/issue#1689_remove_GetVersions
crodriguezvega Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (apps/27-interchain-accounts) [\#2297](https://github.com/cosmos/ibc-go/pull/2297) Adding cli command to generate ICS27 packet data.
* (modules/core/keeper) [\#1728](https://github.com/cosmos/ibc-go/pull/2399) Updated channel callback errors to include portID & channelID for better identification of errors.
* [\#2434](https://github.com/cosmos/ibc-go/pull/2478) Removed all `TypeMsg` constants
* (modules/core/exported) [#1689] (https://github.com/cosmos/ibc-go/pull/2539) Removing `GetVersions` from `ConnectionI` interface.

### Features

Expand Down
1 change: 0 additions & 1 deletion modules/core/exported/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ type ConnectionI interface {
GetClientID() string
GetState() int32
GetCounterparty() CounterpartyConnectionI
GetVersions() []Version
GetDelayPeriod() uint64
ValidateBasic() error
}
Expand Down