verify upgrade timeout path #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/1618-chan-upgrade-init
…datebasic, pull in subset ordering suggestions and adding tests
charleenfei
changed the base branch from
04-channel-upgrades
to
damian/1618-chan-upgrade-init
charleenfei
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## damian/1618-chan-upgrade-init #3342 +/- ##
=================================================================
+ Coverage 78.26% 78.28% +0.02%
=================================================================
Files 186 186
Lines 12961 12987 +26
=================================================================
+ Hits 10144 10167 +23
- Misses 2384 2385 +1
- Partials 433 435 +2
|
chatton
approved these changes
Mar 27, 2023
crodriguezvega
approved these changes
Mar 27, 2023
| err = suite.chainB.GetSimApp().IBCKeeper.ConnectionKeeper.VerifyChannelUpgradeTimeout( | ||
| suite.chainB.GetContext(), | ||
| path.EndpointB.GetConnection(), | ||
| malleateHeight(proofHeight, 0), |
There was a problem hiding this comment.
Just a nit: is the call to malleateHeight necessary is diff is 0?
9 tasks
Base automatically changed from
damian/1618-chan-upgrade-init
to
04-channel-upgrades
March 28, 2023 11:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1610
Commit Message / Changelog Entry
NA
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.