Add VerifyChannelUpgradeSequence method + tests #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/1618-chan-upgrade-init
damiannolan
reviewed
Mar 23, 2023
Co-authored-by: Damian Nolan <[email protected]>
…datebasic, pull in subset ordering suggestions and adding tests
…-verifychannelupgradesequence-method-to-03-connection
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## damian/1618-chan-upgrade-init #3332 +/- ##
=================================================================
+ Coverage 78.24% 78.28% +0.03%
=================================================================
Files 186 186
Lines 12951 12973 +22
=================================================================
+ Hits 10134 10156 +22
+ Misses 2384 2383 -1
- Partials 433 434 +1
|
crodriguezvega
approved these changes
Mar 27, 2023
| upgradeSequenceKey := host.ChannelUpgradeSequenceKey(path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID) | ||
| proof, proofHeight := suite.chainA.QueryProof(upgradeSequenceKey) | ||
|
|
||
| err = suite.chainB.GetSimApp().IBCKeeper.ConnectionKeeper.VerifyChannelUpgradeSequence(suite.chainB.GetContext(), path.EndpointB.GetConnection(), malleateHeight(proofHeight, 0), proof, path.EndpointB.ChannelConfig.PortID, path.EndpointB.ChannelID, expectedUpgradeSequence) |
There was a problem hiding this comment.
Same nit as here :)
There was a problem hiding this comment.
it is almost certainly not required!
…-verifychannelupgradesequence-method-to-03-connection
…-verifychannelupgradesequence-method-to-03-connection
Base automatically changed from
damian/1618-chan-upgrade-init
to
04-channel-upgrades
March 28, 2023 11:20
|
LFG |
chatton
deleted the
cian/issue#1608-add-verifychannelupgradesequence-method-to-03-connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1608
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.