x/ccv/provider/types.SlashLogKey() uses the wrong byte prefix

[tbruyelle]

Summary of Bug

The x/ccv/provider/types.SlashLogKey() function uses the SlashAcksBytePrefix byte prefix instead of SlashLogBytePrefix.

Version

4c318b4

interchain-security/x/ccv/provider/types/keys.go

Lines 447 to 450 in 4c318b4

	// SlashLogKey returns the key to a validator's slash log
	func SlashLogKey(providerAddr ProviderConsAddress) []byte {
	return append([]byte{SlashAcksBytePrefix}, providerAddr.ToSdkConsAddr().Bytes()...)
	}

Steps to Reproduce

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned
• Is a spike necessary to map out how the issue should be approached?

[jtremback]

Great catch! This is definitely a mistake, but luckily it will not cause any problems in production. We'll put a fix in the next release.

Usually, SlashAcksBytePrefix is used to store records having to do with a particular chain id.

For this bug to have any effect at all, someone would need to pass a consumer creation proposal with the chain id being a serialized public key belonging to a validator.

Once this was done, the consumer chain could cause records to be written to the storage location by sending downtime packets. This would then make it possible for someone to create an equivocation slashing governance proposal for the validator with that key. This proposal would then also have to be approved for anything to happen.