Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved key tests #787

Merged
merged 6 commits into from
Apr 4, 2023
Merged

Improved key tests #787

merged 6 commits into from
Apr 4, 2023

Conversation

shaspitz
Copy link
Contributor

Description

Improves key tests s.t they would have caught bugs like this: #785

Type of change

  • Refactor: Changes existing code style, naming, structure, etc.
  • Testing: Adds testing

Regression tests

Existing key tests that were not touched

New behavior tests

New tests in keys_test.go

Versioning Implications

If the above box is checked, which version should be bumped?

  • MAJOR: Consensus breaking changes to both the provider and consumers(s), including updates/breaking changes to IBC communication between provider and consumer(s)
  • MINOR: Consensus breaking changes which affect either only the provider or only the consumer(s)
  • PATCH: Non consensus breaking changes

Targeting

Please select one of the following:

  • This PR is only relevant to main
  • This PR is relevant to main, and should also be back-ported to ____ (ex: v1.0.0 and v1.1.0)
  • This PR is only relevant to ____ (ex: v1.0.0, v1.1.0, and v1.2.0)

@shaspitz
Copy link
Contributor Author

@mpoke this PR will fail as expected until #786 is merged

Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sainoe sainoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpoke mpoke merged commit 75c0652 into main Apr 4, 2023
@mpoke mpoke deleted the improved-key-tests branch April 4, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants