Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ser correct byte prefix for SlashLogKey #786

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Mar 16, 2023

Description

Replace SlashAcksBytePrefix with SlashLogBytePrefix

Linked issues

Closes: #785

Type of change

If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!

  • Feature: Changes and/or adds code behavior, irrelevant to bug fixes
  • Fix: Changes and/or adds code behavior, specifically to fix a bug
  • Refactor: Changes existing code style, naming, structure, etc.
  • Testing: Adds testing
  • Docs: Adds documentation

New behavior tests

If Feature or Fix, describe the new or existing tests that verify the new behavior is correct and expected.

Versioning Implications

If the above box is checked, which version should be bumped?

  • MAJOR: Consensus breaking changes to both the provider and consumers(s), including updates/breaking changes to IBC communication between provider and consumer(s)
  • MINOR: Consensus breaking changes which affect either only the provider or only the consumer(s)
  • PATCH: Non consensus breaking changes

Targeting

Please select one of the following:

  • This PR is only relevant to main
  • This PR is relevant to main, and should also be back-ported to ____ (ex: v1.0.0 and v1.1.0)
  • This PR is only relevant to ____ (ex: v1.0.0, v1.1.0, and v1.2.0)

@shaspitz shaspitz mentioned this pull request Mar 16, 2023
9 tasks
@shaspitz shaspitz merged commit 57d3b54 into main Mar 17, 2023
@shaspitz shaspitz deleted the marius/785-slash-log-byte-prefix branch March 17, 2023 15:32
This was referenced May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/ccv/provider/types.SlashLogKey() uses the wrong byte prefix
3 participants