-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock wrong version of jekyll-sass-converter on Ubuntu 22.04 #848
Comments
cotes2020
added a commit
that referenced
this issue
Jan 11, 2023
Also, make the division formula backward compatible with `jekyll-sass-converter 2.x` (#848, #849) Ref: https://github.com/jekyll/jekyll-sass-converter#migrate-from-2x-to-3x
Gaur4vGaur
added a commit
to Gaur4vGaur/Gaur4vGaur.github.io
that referenced
this issue
Jan 28, 2023
author Gaurav Gaur <[email protected]> 1673866009 +0000 committer Gaurav Gaur <[email protected]> 1674946094 +0000 Jan23 upstream merge (#7) * chore(editorconfig): keep trailing spaces in Markdown (cotes2020#830) * feat(i18n): add Czech language (cotes2020#833) * fix: correct encoding of spaces in share URLs (cotes2020#835) Resolves cotes2020#835 * fix: post's image would cover the PWA update alert * feat(i18n): add Finnish translations (cotes2020#843) * docs: update tutorials - remove outdated content - append instructions for SASS overrides (cotes2020#827) * chore(deps): lock `jekyll-sass-converter` to `v2.x` on Linux-musl (cotes2020#829) Also, make the division formula backward compatible with `jekyll-sass-converter 2.x` (cotes2020#848, cotes2020#849) Ref: https://github.com/jekyll/jekyll-sass-converter#migrate-from-2x-to-3x * chore(bundler): deprecate `:install_if` option in Gemfile * feat(i18n): add Italian translation (cotes2020#850) * fix: copy command line incomplete(`.gp` part) Co-authored-by: Jarda Beran <[email protected]> Co-authored-by: MatyIRG <[email protected]> Co-authored-by: Cotes Chung <[email protected]> Co-authored-by: Kalle Lahtinen <[email protected]> Co-authored-by: Eduardo <[email protected]> feat(i18n): add Czech language (cotes2020#833) fix: correct encoding of spaces in share URLs (cotes2020#835) Resolves cotes2020#835 fix: post's image would cover the PWA update alert feat(i18n): add Finnish translations (cotes2020#843) chore(bundler): deprecate `:install_if` option in Gemfile feat(i18n): add Italian translation (cotes2020#850)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
master
branch.Describe the bug
The commit 9f88426 will lock jekyll-sass-converter to 2.2.0 on Ubuntu 22.04, I think it might be a wrong behavior because the comment tells me that it should only behave on Linux-musl, while
bundle
gives me:More importantly,
calc
does not appear to be supported by jekyll-sass-converter 2.2.0, for an example:jekyll-theme-chirpy/_sass/addon/commons.scss
Lines 837 to 859 in 3a2bdf2
We will get:
To Reproduce
Steps to reproduce the behavior:
I'm not sure if this is my environment issue, I just pulled the latest commits of the master branch and executed
bundle
thenbundle exec jekyll s
.Expected behavior
Lock jekyll-sass-converter to 3.0 on Ubuntu 22.04.
However, I think for users using Linux-musl, the issue about
calc
is still there.Screenshots
Environment
ruby -v
gem -v
bundle -v
bundle exec jekyll -v
bundle info jekyll-theme-chirpy
Desktop
Smartphone
Additional context
The text was updated successfully, but these errors were encountered: