Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock wrong version of jekyll-sass-converter on Ubuntu 22.04 #848

Closed
3 tasks done
NichtsHsu opened this issue Jan 10, 2023 · 0 comments
Closed
3 tasks done

Lock wrong version of jekyll-sass-converter on Ubuntu 22.04 #848

NichtsHsu opened this issue Jan 10, 2023 · 0 comments

Comments

@NichtsHsu
Copy link
Contributor

NichtsHsu commented Jan 10, 2023

Checklist

  • I have read the tutorials and know the correct effect of the functional design.
  • There are no similar reports on existing issues (including closed ones).
  • I found the bug on the latest code of the master branch.

Describe the bug

The commit 9f88426 will lock jekyll-sass-converter to 2.2.0 on Ubuntu 22.04, I think it might be a wrong behavior because the comment tells me that it should only behave on Linux-musl, while bundle gives me:

Using jekyll-sass-converter 2.2.0 (was 3.0.0)

More importantly, calc does not appear to be supported by jekyll-sass-converter 2.2.0, for an example:

@mixin fix-cursor($top) {
top: $top;
visibility: visible;
}
@for $i from 1 through $tab-count {
$offset: $tab-count - $i;
$top: -$offset * $tab-height + calc(($tab-height - $tab-cursor-height) / 2);
@if $i < $tab-count {
> li.active:nth-child(#{$i}),
> li.nav-item:nth-child(#{$i}):hover {
~ li:last-child::after {
@include fix-cursor($top);
}
}
} @else {
> li.active:nth-child(#{$i}):last-child::after,
> li.nav-item:nth-child(#{$i}):last-child:hover::after {
@include fix-cursor($top);
}
}
} /* @for */

We will get:

top: -12remcalc(($tab-height - $tab-cursor-height) / 2);

To Reproduce

Steps to reproduce the behavior:

I'm not sure if this is my environment issue, I just pulled the latest commits of the master branch and executed bundle then bundle exec jekyll s.

Expected behavior

Lock jekyll-sass-converter to 3.0 on Ubuntu 22.04.

However, I think for users using Linux-musl, the issue about calc is still there.

Screenshots

image

Environment

Command Version
ruby -v 3.0.2p107
gem -v 3.3.5
bundle -v 2.3.13
bundle exec jekyll -v 4.3.1
bundle info jekyll-theme-chirpy jekyll-theme-chirpy (5.4.0)

Desktop

  • OS: Ubuntu 22.04
  • Browser: Chrome 108.0.5359.124 (64-bit)

Smartphone

Additional context

cotes2020 added a commit that referenced this issue Jan 11, 2023
Also, make the division formula backward compatible with `jekyll-sass-converter 2.x` (#848, #849)

Ref: https://github.com/jekyll/jekyll-sass-converter#migrate-from-2x-to-3x
Gaur4vGaur added a commit to Gaur4vGaur/Gaur4vGaur.github.io that referenced this issue Jan 28, 2023
author Gaurav Gaur <[email protected]> 1673866009 +0000
committer Gaurav Gaur <[email protected]> 1674946094 +0000

Jan23 upstream merge (#7)

* chore(editorconfig): keep trailing spaces in Markdown (cotes2020#830)

* feat(i18n): add Czech language (cotes2020#833)

* fix: correct encoding of spaces in share URLs (cotes2020#835)

Resolves cotes2020#835

* fix: post's image would cover the PWA update alert

* feat(i18n): add Finnish translations (cotes2020#843)

* docs: update tutorials

- remove outdated content
- append instructions for SASS overrides (cotes2020#827)

* chore(deps): lock `jekyll-sass-converter` to `v2.x` on Linux-musl (cotes2020#829)

Also, make the division formula backward compatible with `jekyll-sass-converter 2.x` (cotes2020#848, cotes2020#849)

Ref: https://github.com/jekyll/jekyll-sass-converter#migrate-from-2x-to-3x

* chore(bundler): deprecate `:install_if` option in Gemfile

* feat(i18n): add Italian translation (cotes2020#850)

* fix:  copy command line incomplete(`.gp` part)

Co-authored-by: Jarda Beran <[email protected]>
Co-authored-by: MatyIRG <[email protected]>
Co-authored-by: Cotes Chung <[email protected]>
Co-authored-by: Kalle Lahtinen <[email protected]>
Co-authored-by: Eduardo <[email protected]>

feat(i18n): add Czech language (cotes2020#833)

fix: correct encoding of spaces in share URLs (cotes2020#835)

Resolves cotes2020#835

fix: post's image would cover the PWA update alert

feat(i18n): add Finnish translations (cotes2020#843)

chore(bundler): deprecate `:install_if` option in Gemfile

feat(i18n): add Italian translation (cotes2020#850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant