Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trim whitespaces in md #830

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Do not trim whitespaces in md #830

merged 1 commit into from
Jan 2, 2023

Conversation

berk76
Copy link
Contributor

@berk76 berk76 commented Dec 30, 2022

Description

Option trim_trailing_whitespace in .editorconfig is switched on globally which is wrong because two trailing spaces has special meaning in md files.

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

  • I have run bash ./tools/test (at the root of the project) locally and passed
  • [ x] I have tested this feature in the browser

Test Configuration

  • Browser type & version:
  • Operating system: Ubuntu Linux
  • Ruby version: 3.0.2
  • Bundler version: 2.3.5
  • Jekyll version: 4.3.1

Checklist

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@cotes2020
Copy link
Owner

Indeed, thanks for the patch

@cotes2020 cotes2020 merged commit 7754a71 into cotes2020:master Jan 2, 2023
sanjidnet pushed a commit to sanjidnet/sanjidnet.github.io that referenced this pull request Jan 9, 2023
linkliu pushed a commit to linkliu/game-tech-post-old that referenced this pull request Jan 9, 2023
Gaur4vGaur added a commit to Gaur4vGaur/Gaur4vGaur.github.io that referenced this pull request Jan 28, 2023
author Gaurav Gaur <[email protected]> 1673866009 +0000
committer Gaurav Gaur <[email protected]> 1674946094 +0000

Jan23 upstream merge (#7)

* chore(editorconfig): keep trailing spaces in Markdown (cotes2020#830)

* feat(i18n): add Czech language (cotes2020#833)

* fix: correct encoding of spaces in share URLs (cotes2020#835)

Resolves cotes2020#835

* fix: post's image would cover the PWA update alert

* feat(i18n): add Finnish translations (cotes2020#843)

* docs: update tutorials

- remove outdated content
- append instructions for SASS overrides (cotes2020#827)

* chore(deps): lock `jekyll-sass-converter` to `v2.x` on Linux-musl (cotes2020#829)

Also, make the division formula backward compatible with `jekyll-sass-converter 2.x` (cotes2020#848, cotes2020#849)

Ref: https://github.com/jekyll/jekyll-sass-converter#migrate-from-2x-to-3x

* chore(bundler): deprecate `:install_if` option in Gemfile

* feat(i18n): add Italian translation (cotes2020#850)

* fix:  copy command line incomplete(`.gp` part)

Co-authored-by: Jarda Beran <[email protected]>
Co-authored-by: MatyIRG <[email protected]>
Co-authored-by: Cotes Chung <[email protected]>
Co-authored-by: Kalle Lahtinen <[email protected]>
Co-authored-by: Eduardo <[email protected]>

feat(i18n): add Czech language (cotes2020#833)

fix: correct encoding of spaces in share URLs (cotes2020#835)

Resolves cotes2020#835

fix: post's image would cover the PWA update alert

feat(i18n): add Finnish translations (cotes2020#843)

chore(bundler): deprecate `:install_if` option in Gemfile

feat(i18n): add Italian translation (cotes2020#850)
Gaur4vGaur added a commit to Gaur4vGaur/Gaur4vGaur.github.io that referenced this pull request Feb 3, 2023
author Gaurav Gaur <[email protected]> 1675074395 +0000
committer Gaurav Gaur <[email protected]> 1675445316 +0000

parent 6c35647
author Gaurav Gaur <[email protected]> 1675074395 +0000
committer Gaurav Gaur <[email protected]> 1675445269 +0000

parent 6c35647
author Gaurav Gaur <[email protected]> 1675074395 +0000
committer Gaurav Gaur <[email protected]> 1675445201 +0000

parent 6c35647
author Gaurav Gaur <[email protected]> 1675074395 +0000
committer Gaurav Gaur <[email protected]> 1675445170 +0000

parent 6c35647
author Gaurav Gaur <[email protected]> 1675074395 +0000
committer Gaurav Gaur <[email protected]> 1675445041 +0000

progress with pipes and filters pattern

feat: add shimmer background when image loads

feat: set preview image ratio to 1.91 : 1

fix: `og:image` will be incorrect if the image uses a cross-domain URL

feat: support dark and light mode images (cotes2020#481)

refactor: unify the border radius of blocks

scope: code blocks, prompts, images, and videos

feat: add `rel="me"` to Mastodon sidebar contact links for verification (cotes2020#807)

This will enable verification with Mastodon by including the `rel="me"` attribute.
https://docs.joinmastodon.org/user/profile/#verification

Co-authored-by: Cotes Chung <[email protected]>

chore: hide blur edge of LQIP images

chore(tools): checkout latest tag on initialization

chore(editorconfig): keep trailing spaces in Markdown (cotes2020#830)

feat(i18n): add Czech language (cotes2020#833)

fix: correct encoding of spaces in share URLs (cotes2020#835)

Resolves cotes2020#835

fix: post's image would cover the PWA update alert

feat(i18n): add Finnish translations (cotes2020#843)

chore(bundler): deprecate `:install_if` option in Gemfile

feat(i18n): add Italian translation (cotes2020#850)

fix:  copy command line incomplete(`.gp` part)

feat(i18n): add Arabic translation (cotes2020#857)

chore(deps): liquid(v4.0.4) is compatible with ruby 3.2 (cotes2020#854)

See: jekyll/jekyll#9231

chore: ignore gem lock file in user-end

refactor: optimize tab cursor position calculation

fix: prompt with nested blockquotes renders incorrectly (cotes2020#846)

Resolves cotes2020#846

chore(release): 5.5.0

fix: the icon position of the prompts in the list is incorrect

chore(release): 5.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants