chore: remove halloween theme #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
force-pushed
the
remove-halloween
branch
from
f6233b1
to
997d60a
Compare
alfetopito
reviewed
Oct 27, 2023
|
|
||
| import { footerImage } from 'common/constants/theme' | ||
| import { footerImage } from 'legacy/theme/cowSwapAssets' |
There was a problem hiding this comment.
what do you mean? this brings the normal CoWs back
There was a problem hiding this comment.
I see you refer to the fact is legacy, but that's where the file is
There was a problem hiding this comment.
I mean, the import was changed away from the legacy path.
I thought it was an improvement.
Comment on lines
211
to
+212
| css` | ||
| position: fixed; | ||
| position: absolute; |
There was a problem hiding this comment.
I have no clue. I didn't notice any change. @fairlighteth WDYT? can you follow up if this is a change that should be done?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove Halloween theme
Reverts:
Additionally it removes Layer3 from the Widgets: f965cf4
questIdto keep it more genericOnce Halloween is over, we can also remove the feature flag from Launch Darky.
Theme is back:
Toggle is back:
Light mode is back:
To Test
No traces of Halloween!