Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uni-merge WIDGET FIX #402

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Uni-merge WIDGET FIX #402

merged 5 commits into from
Apr 14, 2022

Conversation

W3stside
Copy link
Contributor

Summary

fixes widget setup, co-created with @alfetopito @nenadV91

@W3stside W3stside changed the base branch from develop to 2440/uni-merge April 11, 2022 16:56
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good, only a comment regarding modding naming convention

src/custom/lib/components/Widget.tsx Outdated Show resolved Hide resolved
src/custom/lib/components/Widget.tsx Outdated Show resolved Hide resolved
@elena-zh
Copy link

elena-zh commented Apr 13, 2022

I'm not sure if it is related to the current PR or not, but when I press on the 'Buy COW' button, I see that 'Select token' in the From field is missing:
image
image

@alfetopito
Copy link
Collaborator

@elena-zh not likely related to any changes in this PR, but might be related to changes in the parent uni-merge PR

@elena-zh
Copy link

@alfetopito , thank you! Will post it in the #374 PR.

Base automatically changed from 2440/uni-merge to develop April 14, 2022 14:57
@W3stside W3stside merged commit 08e7b07 into develop Apr 14, 2022
@W3stside W3stside deleted the 2440/uni-merge-widget-fix branch April 14, 2022 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants