Improve password change scenario in lockscreen

[acezard]

This pull request includes changes to the validatePassword function in the lockscreen feature. The function now handles several scenarios, including successful validation with cached password, successful validation with user input password, invalid cached password and invalid user input, unexpected server errors, errors in the success handler, and network or communication errors. These changes improve the overall user experience and ensure that the lockscreen feature is more reliable and secure.

[Ldoppea]

Sorry I didn't realize that during dailies, but although this should work, after reading the code I'm not sure what's the advantage of doing this instead of directly doing the checkInputPassword part?

My comprehension is the following:

Seems like all "good" scenario will call /settings/passphrase/check with the password input

If entered password is good, then /settings/passphrase/check is called with the cached password, but as it must be the same as the entered password, this is equivalent to calling it with the entered password. Then onSuccess() is called

If the entered password is good but cache is obsolete, then we end up calling /settings/passphrase/check with entered password. Then onSuccess() is called

If the entered password is bad, then badUnlockPassword is returned whatever if the cached password is bad, or if the input password is bad. So there seems to be no distinction for the user. The only one is that if bad password is entered then 2 http requests are made instead of one.

So would it be simpler if you directly call /settings/passphrase/check only 1 time with input password? And then:

• if 200 and hashedInputPassword.passwordHash === storedHash -> onSuccess()
• if 200 and hashedInputPassword.passwordHash !== storedHash -> updatCache + onSuccess()
• if 403 -> onFailure(errors.badUnlockPassword)
• else -> onFailure(errors.serverError) or onFailure(errors.unknown_error)

I think this would output the same result so unit tests would still be green without any change.

However this PR should work so feel free to merge it

[Ldoppea]

This seems to be redundant with the updateCachedPassword() content that is called just after this method on line 84

[acezard]

updated