fix: don't call getCurrentRoute if nav isn't ready #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will removes error logs at app start when jsCozyInjection was trying to get routeName too fast in the app cycle. Now it will go through the getCurrentRouteName facade which handles non-ready nav objects. Also remove unused injections linked to navigation in useGlobalAppState
zatteo
approved these changes
Nov 27, 2023
|
Nothing to do, but Also remove unused injections linked to navigation in useGlobalAppState could have been another commit. |
acezard
deleted the
fix--don't-call-getCurrentRoute-if-nav-isn't-ready
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will removes error logs at app start when jsCozyInjection
was trying to get routeName too fast in the app cycle.
Now it will go through the getCurrentRouteName facade
which handles non-ready nav objects.
Also remove unused injections linked to navigation in useGlobalAppState