fix: don't fetch for candidateapps at start #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is triggering unecessary rerenders elsewhere in the app when the user doesn't has files to upload. Instead we fetch registry if we detect presence of files. It might be slower in file upload scenario, but it cleans up a lot app start rerenders (file upload state is linked to localMethods)
Crash--
reviewed
Nov 27, 2023
| @@ -62,7 +62,7 @@ export const OsReceiveProvider = ({ | |||
| }, [client?.isLogged]) | |||
|
|
|||
| useEffect(() => { | |||
| if (!client || didCall.current) return | |||
| if (!client || didCall.current || state.filesToUpload.length === 0) return | |||
|
|
|||
| const fetchRegistry = async (): Promise<void> => { | |||
There was a problem hiding this comment.
nit: We do not call the registry. We only call the cozy to fetch the apps. The method name should reflect that and should not be misleading
There was a problem hiding this comment.
That's true, updating
We're not calling the registry but the sack. The distinction is meaningful and should be reflected in the function name
Crash--
approved these changes
Nov 27, 2023
acezard
deleted the
fix--don't-call-registry-for-candidate-apps-at-app-start
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is triggering unecessary rerenders elsewhere in the app
when the user doesn't has files to upload.
Instead we fetch registry if we detect presence of files.
It might be slower in file upload scenario, but it cleans up a lot
app start rerenders (file upload state is linked to localMethods)