Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use null value in all animations config #1052

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: use null value in all animations config #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/view/Loading/RemountProgress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const RemountProgress = (): JSX.Element => {
}

const progressBarConfig = {
width: undefined,
width: null as unknown as number | undefined, // TODO: understand why the width has to be set to null to avoid progress bar to be cut
indeterminate: true,
unfilledColor: palette.Grey[200],
color: palette.Primary[600],
Expand Down
2 changes: 1 addition & 1 deletion src/components/ProgressContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { styles } from '/components/ProgressContainer.styles'
const colors = getColors()

const progressBarConfig = {
width: undefined,
width: null as unknown as number | undefined, // TODO: understand why the width has to be set to null to avoid progress bar to be cut
indeterminate: false,
unfilledColor: palette.Grey[200],
color: colors.primaryColor,
Expand Down
2 changes: 1 addition & 1 deletion src/screens/cozy-app/CozyAppScreen.functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const config = {
// Width has to be null at start even if it's not a valid value (was set to undefined and it broke the progress bar)
// At the time of this fix we want to go back the previously working value but we have to investigate why it has to be null
export const progressBarConfig = {
width: null as unknown as number,
width: null as unknown as number | undefined,
indeterminate: true,
unfilledColor: palette.Grey[200],
color: palette.Primary[600],
Expand Down
Loading