Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install SBRN #1056

Merged
merged 1 commit into from
Dec 11, 2023
Merged

feat: install SBRN #1056

merged 1 commit into from
Dec 11, 2023

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Dec 8, 2023

Storybook usage

yarn storybook will launch the application in storybook mode. This will allow you to view all the components in the application and their various states.

yarn prestorybook is launched automatically before yarn storybook and will update the storybook.requires.js file with the latest components. This is required to ensure that the storybook is up to date.

Refer to the Storybook documentation for more information.

image
image

Known issues:

  • Bad handling of file creation during Metro watch (storybook.requires isn't rebuilt)
  • Should implement a path alias to the Storybook folder

@acezard acezard marked this pull request as ready for review December 11, 2023 09:54
@acezard acezard force-pushed the feat--implement-Storybook branch 2 times, most recently from 8af2bd5 to ef9f2a7 Compare December 11, 2023 14:20
`yarn storybook` will launch the application in storybook mode.
This will allow you to view all the components
in the application and their various states.

`yarn prestorybook` is launched automatically before `yarn storybook`
 and will update the storybook.requires.js file
  with the latest components.
 This is required to ensure that the storybook is up to date.

 # Known issues:
- Bad handling of file creation during
Metro watch (storybook.requires isn't rebuilt)
- Should implement a path alias to the Storybook folder
@zatteo
Copy link
Contributor

zatteo commented Dec 11, 2023

Nice !

@acezard acezard merged commit c6d28d8 into master Dec 11, 2023
1 check passed
@acezard acezard deleted the feat--implement-Storybook branch December 11, 2023 17:01
@Crash--
Copy link
Contributor

Crash-- commented Dec 12, 2023

you should add a line or two in the ./README.md file to share that we know have a storybook here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants