[VIO-104] feat: Implement IAP (part 2) #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
force-pushed
the
feat/iap_part2
branch
from
ac1910c
to
36e3105
Compare
Crash--
reviewed
Dec 13, 2023
| } | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Why don't you use the cozy-stack API to send the notification? I don't know if it's a good thing to directly call fcm.
Ldoppea
force-pushed
the
feat/iap_part2
branch
from
ac31a8e
to
4c2909f
Compare
Ldoppea
force-pushed
the
feat/iap_part2
branch
from
4c2909f
to
a8c0d73
Compare
Ldoppea
force-pushed
the
feat/iap_part2
branch
from
a8c0d73
to
48baad1
Compare
Ldoppea
force-pushed
the
feat/iap_part2
branch
2 times, most recently
from
9c0e02b
to
733228d
Compare
zatteo
reviewed
Dec 21, 2023
| log.debug('Received notification from onMessage event') | ||
|
|
||
| if (!notification.notification?.title || !notification.notification.body) { | ||
| log.error('Received a notification without title or body. Skip.') |
There was a problem hiding this comment.
log.error will go to sentry no ? Is it really needed ?
There was a problem hiding this comment.
Yes. This case should never happen, and if this happens I suppose we should warn the dev team using Sentry.
There was a problem hiding this comment.
Don't you think that one day it will ? Like tomorrow product team may decide that we want a notification with just a title ? And then every user who do not update will trigger the log.
zatteo
approved these changes
Dec 21, 2023
Ldoppea
force-pushed
the
feat/iap_part2
branch
from
733228d
to
4a3bfaa
Compare
Ldoppea
changed the title
acezard
approved these changes
Jan 3, 2024
| flex: 1, | ||
| backgroundColor: colors.primaryColor | ||
| }, | ||
| headerTextStyle: { |
There was a problem hiding this comment.
Wondering why we don't use our Typography component instead
Ldoppea
force-pushed
the
feat/iap_part2
branch
from
4a3bfaa
to
7be686a
Compare
Ldoppea
force-pushed
the
feat/iap_part2
branch
3 times, most recently
from
550277d
to
dbda917
Compare
Ldoppea
force-pushed
the
feat/iap_part2
branch
from
dbda917
to
0cd2de4
Compare
When Android IAP is processed by the Cloudery, the Cozy's base domain is required to differentiate between test and production environments
This package is needed by the following commits to handle restart push notifications We target version `0.0.24` to ensure compatibility with react-native `0.66`
When the IAP is received by the Cloudery, it should change the Cozy's plan and then send a push notification to the user's apps This notification's goal is to tell the user that the Cozy's migration has been done, but also to restart the app when the user is ready to do it The app restart is required so we are sure all new plan related flags are applied
Google allows to get multiple subscription at the same time, so when the user upgrade or downgrade their offer, then we need to revoke the old one. To allow this we need to provide the `purchaseToken` to the request. This info is provided by the Cloudery using the `purchaseToken` query string Then we also need to specify how proration is calculated, the app does not make this choice, instead the Cloudery provide the info through the `prorationMode` query string
The stores require us to display localized prices and descriptions to the user when displaying IAP options So we want to provide them to the Cloudery using the `iap_offers` query parameter
When `isFlagship=true` is given to the OAuthClientsLimit route, then cozy-stacks will open links as new windows This was a requested feature to ease detection of cozy-app opening requests To handle this new behaviour we have to copy the interception code from `interceptNavigation` into `interceptOpenWindow`
We want to reduce noise in console logs and FlagshipUI changes are not so useful when not debuging this specific feature
Ldoppea
force-pushed
the
feat/iap_part2
branch
from
0cd2de4
to
8a31cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
restartpush notifications