Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid undefined is not a function error in onWorkerError #1073

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

doubleface
Copy link
Contributor

Also :

  • check if the launcher is present
  • log a stringified version of the event in konnector log when possible
  • or else log stringified version of the event in flagship app console
  • apply this same logic to onWorkerError, onPilotError, onPilotWebviewKilled, onWorkerWebviewKilled

Checklist

Before merging this PR, the following things must have been done:

  • Faithful integration of the mockups at all screen sizes
  • Tested on iOS
  • Tested on Android
  • Localized in English and French
  • All changes have test coverage
  • Updated README & CHANGELOG, if necessary

Also :
- check if the launcher is present
- log a stringified version of the event in konnector log when possible
- or else log stringified version of the event in flagship app console
- apply this same logic to onWorkerError, onPilotError, onPilotWebviewKilled, onWorkerWebviewKilled
@doubleface doubleface merged commit 4048c81 into master Dec 14, 2023
1 check passed
@doubleface doubleface deleted the fix/onWorkerErrorCrash branch December 14, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants