feat: Send existing files index to pilot fetch #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Dec 21, 2023
| const serializableExistingFilesIndex = | ||
| Object.fromEntries(existingFilesIndex) | ||
| pilotContext.existingFilesIndex = serializableExistingFilesIndex | ||
| } |
There was a problem hiding this comment.
Since the flagship app will have more and more to check the permissions. We should start creating a new domain (aka folder) to deal with that instead of adding the complexity here
There was a problem hiding this comment.
Can you add a wrapTime to that method?
There was a problem hiding this comment.
A wrapTime to _start or hasPermission ? I'm not sure
There was a problem hiding this comment.
Already done :
doubleface
force-pushed
the
feat/existingFilesIndex
branch
from
6ddd6b1
to
d3bee1d
Compare
This index is sent only if the konnector has a permission on io.cozy.files, to avoid unneccessary requests. This existing files index is needed to have `shouldReplaceFile` functionnal in konnectors. But shouldReplaceFile won't throw if it is not present.
doubleface
force-pushed
the
feat/existingFilesIndex
branch
from
d3bee1d
to
1a5b00e
Compare
Crash--
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This index is sent only if the konnector has a permission on
io.cozy.files, to avoid unneccessary requests.
This existing files index is needed to have
shouldReplaceFilefunctionnal in konnectors. But shouldReplaceFile won't throw if it is
not present.
Checklist
Before merging this PR, the following things must have been done: