Update album for dedup before upload #1118
Conversation
zatteo
force-pushed
the
feat/dedup-before-upload
branch
from
0fc50c0
to
c0e4f70
Compare
zatteo
force-pushed
the
feat/album-dedup
branch
from
9295138
to
7585b64
Compare
There was a problem hiding this comment.
My understanding is that you don't use the backupDeviceIds value on Albums anymore.
So do we really still need it? (vs a fromBackup boolean)
If yes, shouldn't you add the new iPhone ID to the Album's list of backupDeviceIds if it contains only the old iPhone ID?
I do not use them anymore for albums, but I decided to rely on their existence because they are already here for current backup user. If I started from scratch I would have added a 'fromBackup' boolean like you said. But I agree that it is confusing to use it without updating it. I think about it. Maybe I will just write some comment/doc about it. |
zatteo
force-pushed
the
feat/dedup-before-upload
branch
from
c0e4f70
to
4843eda
Compare
We do not use this function since we decided to create album during upload and not at the beginning (d5c237f)
If a media has been deduplicated, we still want to add it to its albums on Cozy Photos.
Before, backup created remote albums with a device id in metadata. And only remote albums with the good device id were used by a backup. With dedup mode, we do not want anymore this mechanism because we can : - take 100 photos with an iPhone 12 and put them in an iOS album "Holiday" - upload 100 photos with backup and put them in a Cozy Photos album "Holiday" - buy an iPhone 15 and migrate with Apple our iOS photos and iOS albums in the new iPhone 15 - take 10 new photos and put them in iOS album "Holiday" - upload 10 photos with backup (previous 100 photos will not be uploaded because deduplicated) => even if if is not the same device id, we want to have the 110 photos in the same "Holiday" album on Cozy Photos So now we use remote albums if they *have* a backupDeviceIds <=> if they have been created by a backup.
zatteo
force-pushed
the
feat/album-dedup
branch
from
7585b64
to
2a34c31
Compare
Adjust album management with dedup #1114