feat: Handle planId parameter in startIap url, pass language code to Cloudery and improve IAP
#1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
force-pushed
the
feat/iap_part2
branch
from
0cd2de4
to
8a31cdf
Compare
Ldoppea
force-pushed
the
feat/iap_part3
branch
from
b154201
to
c1cd2a4
Compare
In previous implementation the cloudery did pass only a `productId` parameter that would contain a `planId` on Android platform With the new implementation, the cloudery passes the `planId` in a new parameter in addition to the `productId` that now always contains the real `productId` on both platforms This simplifies the `getSubscriptionOffers` method that does not require a nested map anymore in order to retrieve the missing `productId`
The stores require us to display localized prices and descriptions to the user when displaying IAP options Our understanding is that descriptions and prices should displayed using the phone's language (vs the cozy's language) So we want to provide the phone's language code to the Cloudery using the `lang` query parameter
Ldoppea
force-pushed
the
feat/iap_part3
branch
from
c1cd2a4
to
828ac6d
Compare
zatteo
reviewed
Jan 16, 2024
| @@ -116,9 +117,12 @@ export const useClouderyOffer = (): ClouderyOfferState => { | |||
| setPopupUrl(null) | |||
| } else { | |||
| const offersParam = formatOffers(subscriptions) | |||
| const lang = getLocales()[0].languageCode | |||
There was a problem hiding this comment.
We have getDeviceLanguage that does the same job in our wrapper src/locales/i18n.ts
There was a problem hiding this comment.
Yep but it is not exported, so after talking with @acezard we chose to directly call getLocales() here instead of exporting the other method.
zatteo
reviewed
Jan 16, 2024
| await getSubscriptions({ skus: SKUS }) | ||
| setPartialPopupUrl(current => current ?? href) | ||
| } catch (error: unknown) { | ||
| const errorMessage = getErrorMessage(error) |
There was a problem hiding this comment.
:o I finally understood the purpose of getErrorMessage. I will use it in backup feature...
zatteo
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR for IAP before merging everything
feat: Handle planId parameter in startIap url
In previous implementation the cloudery did pass only a
productIdparameter that would contain a
planIdon Android platformWith the new implementation, the cloudery passes the
planIdin a newparameter in addition to the
productIdthat now always contains thereal
productIdon both platformsThis simplifies the
getSubscriptionOffersmethod that does notrequire a nested map anymore in order to retrieve the missing
productIdfeat: Add device's language code to Cloudery url when displaying offers
The stores require us to display localized prices and descriptions to
the user when displaying IAP options
Our understanding is that descriptions and prices should displayed
using the phone's language (vs the cozy's language)
So we want to provide the phone's language code to the Cloudery using
the
langquery parameter