Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not manage shareFiles errors in flagship app #1144

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Jan 26, 2024

We need on the front side to know if :

  • share succeeded
  • share was canceled
  • share failed

So let's not catch everything here.

We need on the front side to know if :
- share succeeded
- share was canceled
- share failed

So let's not catch everything here.
Copy link
Contributor

@acezard acezard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this linked to a ticket?

@zatteo
Copy link
Contributor Author

zatteo commented Jan 30, 2024

is this linked to a ticket?

Indirectly where I need to implement this on mespapiers.

@zatteo zatteo merged commit d64b70b into master Jan 30, 2024
1 check passed
@zatteo zatteo deleted the fix/return-share-file-error-when-did-not-sent branch January 30, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants