feat: add a timeout for splashscreen (VO-321) #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to instability we decide to hide the splashcreen after a set value (here 15s). A message will also be sent to Sentry should that error arise. This is mainly to prevent infinitely stuck splashscreen while the app below is still functioning
acezard
force-pushed
the
feat--add-a-timeout-for-splashscreen
branch
from
2bdabda
to
d5c4fe0
Compare
This will fix failing tests with conflicting mocks
acezard
force-pushed
the
feat--add-a-timeout-for-splashscreen
branch
from
d5c4fe0
to
3db5710
Compare
zatteo
reviewed
Jan 31, 2024
zatteo
reviewed
Jan 31, 2024
src/app/theme/SplashScreenService.ts
Outdated
| clearTimeout(autoHideTimer) | ||
| } | ||
|
|
||
| autoHideTimer = setTimeout(() => { |
There was a problem hiding this comment.
I am not sure about it, but I think we will autohide the secure_background splash screen and this one should not use autohide.
zatteo
reviewed
Jan 31, 2024
This splashscreen is a special case and should not be interfered with regarding timeout timers.
zatteo
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to instability we decide to hide the splashcreen after a set value
(here 15s).
A message will also be sent to Sentry should that error arise.
This is mainly to prevent infinitely stuck splashscreen while the app
below is still functioning