-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implement alternative tar.gz on old android (VO-310) #1170
fix: implement alternative tar.gz on old android (VO-310) #1170
Conversation
9e4fa20
to
cd8828f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have too comments about this.
First, why did you create the repository in the cozy-labs
org instead of instead of the cozy
one? There are already a few react-native forks in the cozy
one (cf here)
Also, I would suggest to use only PRs in those repositories, this would help to list all Cozy's edits from a single search (the PR page) in the future.
However this is nit as I don't expect the original repo to suddenly get new commits in the future, so we won't need to do a merge upstream. But keep in mind that for other repos using PRs would ease a lot.
Also I added 2 comments to the new repo's commits, I don't know how to keep track of them as they are not in a PR so I put them here:
you're right it should be in cozy namespace, and use PR rather than commit to main directly. Also keep history of the first change and check why it was made exactly
|
cd8828f
to
bde6c4c
Compare
bde6c4c
to
62fb567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks for your efforts 🎉
🐛 Bug Fixes
Please refer to fix: update apache commons and support older api react-native-gzip#2 for the actual fix implementation