Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use default empty object in setInstanceData (VO-380) #1177

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: use default empty object in setInstanceData (VO-380) #1177

merged 1 commit into from
Feb 26, 2024

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Feb 26, 2024

Without it, we risk destructuring an undefined value

@acezard
fix: use default empty object in setInstanceData
d12666e 
Without it, we risk destructuring an undefined value
Ldoppea
Ldoppea approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@Ldoppea Ldoppea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@acezard acezard merged commit 44b12fb into master Feb 26, 2024
1 check passed
@acezard acezard deleted the fix--use-default-empty-object-in-setInstanceData branch February 26, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ldoppea Ldoppea Ldoppea approved these changes

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acezard @Ldoppea