fix: Laucher ensureKonnectorFolder tests #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test were really testing ensureKonnectorFolder from cozy-client and not Launcher.ensureAccountTriggerAndLaunch. And we could get different results depending on computer locale if the test did not define proper mocks. Now these tests test the feature with the proper level
acezard
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test were really testing ensureKonnectorFolder from cozy-client
and not Launcher.ensureAccountTriggerAndLaunch. And we could get
different results depending on computer locale if the test did not
define proper mocks.
Now these tests test the feature with the proper level