[VER-421] fix: Correctly inject body classes when <body> has no attributes
#1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
changed the title
<body> has no attributes<body> has no attributes
Previous regex would inject body classes in the wrong place if the body
has no attributes but its child div has class attribute
In that case, the function would inject the classes in the child div
classes
With previous regex the following HTML
```html
<html>
<head></head>
<body>
<div class="application"></div>
</body>
</html>
```
Would output
```html
<html>
<head></head>
<body>
<div class="application flagship-app flagship-os-ios flagship-route-home"></div>
</body>
</html>
```
With new regex, it outputs
```html
<html>
<head></head>
<body class="flagship-app flagship-os-ios flagship-route-home">
<div class="application"></div>
</body>
</html>
```
This also fixes a production bug where we found that a `div` with same
value for `role` and `class` would see values injected in its `role`
instead of its `class` (this only happens if `role` is declared first)
With previous regex the following HTML
```html
<html>
<head></head>
<body>
<div role="application" class="application"></div>
</body>
</html>
```
Would output
```html
<html>
<head></head>
<body>
<div role="application flagship-app flagship-os-ios flagship-route-home" class="application"></div>
</body>
</html>
```
This would break `document.querySelector("[role=application]")` call
made by our libraries
This commit fixes this observed bug, but this is a side effect as we
now ensure that only the `<body>` tag is impacted
But the bug would reappear if someday some of our apps has similar
pattern inside of their `body` tags (this is not the case today)
Ldoppea
force-pushed
the
fix/ecolyo_injection
branch
from
f689ee0
to
5a8f627
Compare
Crash--
approved these changes
Mar 23, 2024
zatteo
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous regex would inject body classes in the wrong place if the body has no attributes but its child div has class attribute
In that case, the function would inject the classes in the child div classes
With previous regex the following HTML
Would output
With new regex, it outputs
This also fixes a production bug where we found that a
divwith same value forroleandclasswould see values injected in itsroleinstead of itsclass(this only happens ifroleis declared first)With previous regex the following HTML
Would output
This would break
document.querySelector("[role=application]")call made by our librariesThis commit fixes this observed bug, but this is a side effect as we now ensure that only the
<body>tag is impactedBut the bug would reappear if someday some of our apps has similar pattern inside of their
bodytags (this is not the case today)