Add SharedMemory service #1208
Merged
Add SharedMemory service #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
force-pushed
the
feat/resilient-scan
branch
from
852e689
to
a723d87
Compare
zatteo
changed the title
zatteo
changed the title
zatteo
force-pushed
the
feat/resilient-scan
branch
from
a723d87
to
b4a68c5
Compare
4 tasks
acezard
approved these changes
May 27, 2024
Ldoppea
reviewed
May 28, 2024
| type Base64 = string | ||
|
|
||
| export const scanDocument = async (): Promise<Base64 | undefined> => { | ||
| try { | ||
| removeSharedMemory('mespapiers', 'scanDocument') |
There was a problem hiding this comment.
Do we really want to clear this before doing the OS scan (that may produce memory flush too)? Would it be better to do this the later we can?
There was a problem hiding this comment.
What do you mean by memory flush ?
It has no meaning to do this cleaning later. But this cleaning is not necessary. It is just that if we are in this function this value has no meaning anymore because we overwrite it a few lines later.
Maybe I can remove it.
zatteo
force-pushed
the
feat/resilient-scan
branch
from
e6a4432
to
8392671
Compare
Ldoppea
approved these changes
Jun 13, 2024
This SharedMemory service is an in memory store used to store data that can be retrieved later by Cozy webviews.
Sometimes, the operating system kill the mespapiers webview during a 'scanDocument' due to memory constraints. But the 'scanDocument' still run successfully. So we store the result in SharedMemory service so that the mespapiers webview will be able to retrieve it when it will be reloaded by the SupervisedWebview.
To improve security, we want to be sure that a webview only read the shared memory from this webview. So we check the slug added by cozy-intent. We also need to register this slug.
zatteo
force-pushed
the
feat/resilient-scan
branch
from
8392671
to
66c2949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR : cozy/cozy-libs#2540
Checklist
Before merging this PR, the following things must have been done if relevant:
Todo
Merge cozy/cozy-libs#2548 and update cozy-intent