Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progress bar color in dark mode #1228

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix progress bar color in dark mode #1228

merged 1 commit into from
Jul 10, 2024

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Jul 10, 2024 •
edited
Loading 

### ✨ Features

*

### 🐛 Bug Fixes

* 

### 🔧 Tech
 
* Fix progress bar color in dark mode

Checklist

Before merging this PR, the following things must have been done if relevant:

  • Tested on iOS
  • Tested on Android
  • Test coverage
  • README and documentation

@zatteo
fix: Compute progress bar colors at call
056257b 
When need to compute colors at call because we check the darkmode flag and Appearance.colorScheme to determine colors.
@zatteo zatteo merged commit be66e45 into master Jul 10, 2024
1 check passed
@zatteo zatteo deleted the fix/progress-bar-color branch July 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acezard acezard Awaiting requested review from acezard acezard is a code owner

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zatteo