Add 'ocr', 'scanner' and 'backup' features to isAvailable #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decided to move from isFeatureAvailable() to isAvailable(featureName: string) to check if a feature is available. isOcrAvailable has not been released yet. So let's move it now before having to handle a breaking change.
We decided to move from isFeatureAvailable() to
isAvailable(featureName: string) to check if a feature is available.
These feature have already been released in production. So I add the
possibility here to check if they are present by calling
isAvailable('scanner') or isAvailable('backup') but I do not remove
isScannerAvailable method and backup_available injected variable.
We will need to wait that the new isAvailable is released and
distributed to all of our users before removing the deprecated
methods.
Ldoppea
approved these changes
Oct 20, 2023
src/libs/intents/localMethods.ts
Outdated
| @@ -251,9 +257,8 @@ export const localMethods = ( | |||
| openAppOSSettings, | |||
| isNativePassInstalledOnDevice, | |||
| scanDocument, | |||
| isScannerAvailable: () => Promise.resolve(isScannerAvailable()), | |||
| isScannerAvailable: () => Promise.resolve(isScannerAvailable()), // deprecated | |||
There was a problem hiding this comment.
maybe we can console log in this method to alert about deprectated method?
zatteo
force-pushed
the
feat/migrate-is-available
branch
from
5dd0dbc
to
c49b094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Support 'ocr' feature in isAvailable
We decided to move from isFeatureAvailable() to isAvailable(featureName: string) to check if a feature is available.
isOcrAvailable has not been released yet. So let's move it now before having to handle a breaking change.
refactor: Support 'scanner' and 'backup' feature in isAvailable
We decided to move from isFeatureAvailable() to
isAvailable(featureName: string) to check if a feature is available.
These feature have already been released in production. So I add the
possibility here to check if they are present by calling
isAvailable('scanner') or isAvailable('backup') but I do not remove
isScannerAvailable method and backup_available injected variable.
We will need to wait that the new isAvailable is released and
distributed to all of our users before removing the deprecated
methods.