fix: Add check on language files and add missing translations for en and es files #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KillianCourvoisier can you review the new Spanish translations? |
Ldoppea
force-pushed
the
fix/es_translations
branch
from
5696e6d
to
1bd78f7
Compare
zatteo
reviewed
Nov 8, 2023
white_label/configure-brand.ts
Outdated
|
|
||
| const areExtraFrEquivalent = areExtraLanguagesEquivalent('en') | ||
| const areExtraEnEquivalent = areExtraLanguagesEquivalent('en') | ||
| const areExtraEsEquivalent = areExtraLanguagesEquivalent('fr') |
There was a problem hiding this comment.
en en fr where as it should be fr en es? Or I did not understand?
There was a problem hiding this comment.
const extraLanguages = ['fr', 'en', 'es']
const areExtraLangagesOk = extraLanguages.every(extraLanguage => areExtraLanguagesEquivalent(extraLanguage))
seems just as clear and less prone to error for me
There was a problem hiding this comment.
Nice catch, i fixed it here
Some considerations:
- I applied your suggestion also for
areLanguagesEquivalentcalls - This implies that there will be a useless call to
areLanguagesEquivalent('en', 'en'), comparing english to itself- I consider this not a problem as the result will be always be
trueand this is fast enough to not be perceived. Is is acceptable considering the improvement in code readibility
- I consider this not a problem as the result will be always be
- I could have put
areLanguagesEquivalentandareExtraLanguagesEquivalentin the same loop, but I prefer it this way so the console prints will be grouped by file type (languages, then extra-languages)
Ldoppea
force-pushed
the
fix/es_translations
branch
from
1bd78f7
to
2bd5d7d
Compare
zatteo
approved these changes
Nov 10, 2023
Some languages files were missing translations and also extra languages were not in sync with each other in white labels Those new checks should ensure that all langages files contain the same keys and that all extra language override the same keys
zatteo
force-pushed
the
fix/es_translations
branch
from
2bd5d7d
to
5e54766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some languages files were missing translations and also extra languages were not in sync with each other in white labels
Those new checks should ensure that all langages files contain the same keys and that all extra language override the same keys